CombineCommunity / CombineCocoa

Combine publisher bridges for UIKit

MIT License

1.67k stars 133 forks source link

Increase deployment target to iOS11 #57

Closed TTOzzi closed 3 years ago

TTOzzi commented 3 years ago

Fixes #56

As indicated in the Xcode 13 release note (https://developer.apple.com/documentation/xcode-release-notes/xcode-13-release-notes)

Known Issues
Swift libraries depending on Combine may fail to build for targets including armv7 and i386 architectures. (82183186, 82189214) Workaround: Use an updated version of the library that isn’t impacted (if available) or remove armv7 and i386 support (for example, increase the deployment target of the library to iOS 11 or higher).

So I increased deployment target to iOS11 in CocoaPod and SPM. While this is not optimal, it is at least a functioning workaround for now. 🤔

codecov[bot] commented 3 years ago

Codecov Report

Merging #57 (86e7ec6) into main (ab4bfcc) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   71.55%   71.55%           
=======================================
  Files          28       28           
  Lines         566      566           
=======================================
  Hits          405      405           
  Misses        161      161

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab4bfcc...86e7ec6. Read the comment docs.

rodrigopriolo commented 3 years ago

please approve this

TTOzzi commented 3 years ago

hey @rodrigopriolo! This problem seems to be resolved at #58 You can install resolved version from main branch 😃