search

CombineCommunity / CombineCocoa

Combine publisher bridges for UIKit
MIT License
1.65k stars 132 forks source link

Memory Leaks in TapPublisher #68

Open DispoKen opened 2 years ago

DispoKen commented 2 years ago

Describe the bug We seems to be getting memory leaks with TapPublisher.

To Reproduce Steps to reproduce the behavior: Add a tapPublisher on a tapRecognizer Expected behavior No Memory Leaks

Screenshots

Screen Shot 2022-03-03 at 9 27 13 PM Screen Shot 2022-03-03 at 9 32 38 PM Screen Shot 2022-03-03 at 9 32 47 PM

Device:

Additional context None

kkizlaitis commented 2 years ago

I have encountered this (or very similar) issue as well. There are lots of _UIBarButtonItems who seem to have a strong reference to UITapGestureRecognizer. The key thing is that the issue appears even when not using the library. If I just add CombineCocoa as a dependency in Cocoapods, the leaks happen. If I remove the dependency from Cocoapods, the leaks are gone.

freak4pc commented 2 years ago

Can you please drop a reproducible project here? Thanks!

brannpark commented 1 year ago

Any updates for this?