search

CombineCommunity / CombineCocoa

Combine publisher bridges for UIKit
MIT License
1.67k stars 133 forks source link

tvOS support #79

Closed RomanPodymov closed 4 months ago

RomanPodymov commented 2 years ago

Hello. Thank you for CombineCocoa. CombineCocoa now supports tvOS.

RomanPodymov commented 1 year ago

Hello @freak4pc Any updates?

markst commented 1 year ago

+1

markst commented 11 months ago

Would be cool to add: https://developer.apple.com/documentation/uikit/uicollectionviewdelegate/1618081-collectionview

RomanPodymov commented 11 months ago

Would be cool to add: https://developer.apple.com/documentation/uikit/uicollectionviewdelegate/1618081-collectionview

Hello @markst First of all we need to merge this pull request.

batkov commented 7 months ago

FYI, this PR has not been properly tested and is not working on tvOS as expected. I found that UIButton.tapPublisher is not functioning.

Probably more issues will arise.

markst commented 7 months ago

I found that UIButton.tapPublisher is not functioning.

You shouldn't be using "UIControlEvents.TouchUpInside" on tvOS, since that doesn't do what you might expect: you probably want to use "UIControlEvents.PrimaryActionTriggered" instead.

TouchUpInside is triggered by actual touches, which isn't really what you wanted here: if you want the Select button press on the remote to trigger your button, you should use PrimaryActionTriggered.