search

CombineCommunity / CombineExt

CombineExt provides a collection of operators, publishers and utilities for Combine, that are not provided by Apple themselves, but are common in other Reactive Frameworks and standards.
https://combine.community
MIT License
1.72k stars 151 forks source link

Add `RetryWithBehaviour` #110

Closed HugoSay closed 1 year ago

HugoSay commented 2 years ago

This PR Adds RetryWithBehaviour Operator.

The implementation was largely inspired by (copied from and adapted to be honest) the one on the RxSwiftExt Package

I'd love some feedbacks on this.

HugoSay commented 2 years ago

This is kind of linked to @danielt1263's https://github.com/CombineCommunity/CombineExt/pull/101

HugoSay commented 2 years ago

I'll add some documentation if the operator is worthy 😃

codecov[bot] commented 2 years ago

Codecov Report

Merging #110 (80544cb) into main (0880829) will increase coverage by 0.09%. The diff coverage is 99.09%.

:exclamation: Current head 80544cb differs from pull request most recent head 4b04c85. Consider uploading reports for the commit 4b04c85 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   97.12%   97.22%   +0.09%     
==========================================
  Files          62       64       +2     
  Lines        3338     3563     +225     
==========================================
+ Hits         3242     3464     +222     
- Misses         96       99       +3
Impacted Files Coverage Δ
Tests/RetryWithBehaviourTests.swift 98.89% <98.89%> (ø)
Sources/Operators/RetryWithBehaviour.swift 100.00% <100.00%> (ø)
Sources/Operators/Internal/Lock.swift 80.00% <0.00%> (-3.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0880829...4b04c85. Read the comment docs.