search

CombineCommunity / CombineExt

CombineExt provides a collection of operators, publishers and utilities for Combine, that are not provided by Apple themselves, but are common in other Reactive Frameworks and standards.
https://combine.community
MIT License
1.73k stars 155 forks source link

Remove stray exported import of Foundation. #147

Closed jasdev closed 2 years ago

jasdev commented 2 years ago

Follow up PR for https://github.com/CombineCommunity/CombineExt/issues/145

jasdev commented 2 years ago

(cc @freak4pc πŸ™πŸ½)

codecov[bot] commented 2 years ago

Codecov Report

Merging #147 (7be5bbd) into main (d69aab9) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 7be5bbd differs from pull request most recent head b8601cc. Consider uploading reports for the commit b8601cc to get more accurate results

@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          72       72           
  Lines        4284     4284           
=======================================
  Hits         4090     4090           
  Misses        194      194
Impacted Files Coverage Ξ”
Sources/Operators/Internal/Timer.swift 65.78% <ΓΈ> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nebsta commented 2 years ago

When can we expect to have this merged into main? We're still having issues with building documentation as a result of the Foundation import, so it would be nice to get this in

jasdev commented 2 years ago

Defer to @freak4pc since I don't have merge permissions. πŸ™πŸ½