Open Kn1kt opened 1 year ago
Mind taking a look? @danielt1263
I'll have a look this weekend.
Good catch @Kn1kt. I have updated the test based on your suggestion and updated the code to make the test pass while still passing the other tests. See PR #150
Good job. I also made a couple of fixes that can be merged after your PR. #151
Just had this bite me in the rear with API requests. @danielt1263 's PR fixed my issue.
I also spent some time debugging this issue, can we merge @danielt1263's PR? Thanks!
@freak4pc Pls check @danielt1263 's PR. Thanks
Looks like this PR stuck. I have improved this operator, you can check out it here: CombineKit. Hope this helps
Now RetryWhen subscribes to upstream twice. This is because the Sink itself subscribes to the upstream in .init. Test testSuccessfulRetry() checks the number of subscriptions, but not correctly. It should check that the error publisher produces at least one item.
The correct test should look like this:
A possible solution is to remove upstream subscription from Sink.init and setting upstreamIsCancelled cancelUpstream function.