search

CombineCommunity / CombineExt

CombineExt provides a collection of operators, publishers and utilities for Combine, that are not provided by Apple themselves, but are common in other Reactive Frameworks and standards.
https://combine.community
MIT License
1.72k stars 151 forks source link

Update `testSuccessfulRetry` and code to make it pass. #150

Open danielt1263 opened 1 year ago

danielt1263 commented 1 year ago

Update based on observation by @Kn1kt in issue #148

codecov[bot] commented 1 year ago

Codecov Report

Merging #150 (b8ec4a3) into main (d7b896f) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   95.47%   95.49%   +0.02%     
==========================================
  Files          72       72              
  Lines        4284     4287       +3     
==========================================
+ Hits         4090     4094       +4     
+ Misses        194      193       -1
Impacted Files Coverage Δ
Sources/Operators/RetryWhen.swift 89.74% <100.00%> (-0.26%) :arrow_down:
Tests/RetryWhenTests.swift 94.66% <100.00%> (+1.70%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

robnadin commented 1 year ago

What's the status of this and #151? Any reason they are not merged?

WoodyHang commented 11 months ago

Again, why not merge, I need to use this operator now @danielt1263

danielt1263 commented 11 months ago

Again, why not merge, I need to use this operator now @danielt1263

I don't think I have control over when this gets merged. Maybe @freak4pc could chime in here?