Fix memory leak issue with PassthroughRelay

CombineCommunity / CombineExt

CombineExt provides a collection of operators, publishers and utilities for Combine, that are not provided by Apple themselves, but are common in other Reactive Frameworks and standards.

https://combine.community

MIT License

1.72k stars 151 forks source link

Fix memory leak issue with PassthroughRelay #168

Open just1103 opened 7 months ago

just1103 commented 7 months ago

Fixed a memory leak with PassthroughRelay as described in this issue #167.

It appears that PassthroughRelay fails to release its subscriptions upon receiving completion, as similarly described in this PR #85.

I've confirmed the disappearance of the retain cycle with this solution in my project, but I'm not fully proficient with Combine. So, Any comments or suggestions would be greatly appreciated.

just1103 commented 7 months ago

Hello @freak4pc Could you please review this PR?