Discussion around fragility of function overrides - we have a decent amount of these in the framework. We should ideally have some way of detecting these changing underneath the framework and fail-safe if that happens.
From #215:
> I'm not sure what we'd do with this if it happens - I guess we'd want to fail safely, add fallback behaviour? Sounds good because we should be taking special care when we're overriding things. Also sounds like creep, so I think let's put it in another ticket.
Agreed on both points. We already have a pretty strong dependency on specific ACRE and ACE functions being present, to the point where undesirable things happen when they're sudenly not there anymore. I think cementing this dependency with proper error checks (think assertions) somewhere, ideally in an init function, would be an appropriate step. Not only would we be able to inform the mission maker better via error messages (this could be done in a number of ways), but we'd be able to catch these issue early - at the very least before a scheduled event.
Definitely worth shoving into another ticket, though. We'll have to give it a proper think in order to decide how to best approach it. Let's put that on the backburner.
Discussion around fragility of function overrides - we have a decent amount of these in the framework. We should ideally have some way of detecting these changing underneath the framework and fail-safe if that happens.
From #215:
Agreed on both points. We already have a pretty strong dependency on specific ACRE and ACE functions being present, to the point where undesirable things happen when they're sudenly not there anymore. I think cementing this dependency with proper error checks (think assertions) somewhere, ideally in an init function, would be an appropriate step. Not only would we be able to inform the mission maker better via error messages (this could be done in a number of ways), but we'd be able to catch these issue early - at the very least before a scheduled event.
Definitely worth shoving into another ticket, though. We'll have to give it a proper think in order to decide how to best approach it. Let's put that on the backburner.
Originally posted by @Cre8or in https://github.com/CombinedArmsGaming/CAFE3/issues/215#issuecomment-2074169724