search

CombinedArmsGaming / CAFE3

F3_CA but bouncier.
2 stars 3 forks source link

[Bug] Slotting Generator HATES Overflow Slots, CLICK NOW TO FIND OUT WHY #228

Open dgibso29 opened 2 months ago

dgibso29 commented 2 months ago

Describe the bug Slotting generator is bamboozled when crafty Mission Makers SLAM role descriptions with "(Overflow)" and fails to create an appropriate short code.

To Reproduce Steps to reproduce the behavior:

  1. Make slot with (Overflow) in the role description.
  2. Generate slotting post
  3. Behold the long short code

Expected behavior Parentheses don't break Short Code generation, or at the very least the common "(Overflow)" pattern is handled.

Screenshots Slotting Output image

Environmental Info(please complete the following information):

Additional context Probably just an issue with parsing parentheses or other special characters. Not exactly a huge deal to fix in the output but could confuse people that aren't us.

Bubbus commented 2 months ago

Is this a documentation issue? Does this help? https://github.com/CombinedArmsGaming/CAFE3/blob/develop/configuration/slottingGenerator.hpp#L37

dgibso29 commented 2 months ago

Whoopsie, nope; I simply forgot about this note.

FWIW: I saw this as a problem stemming from Parentheses. It might be worth looking for an ignoring "(Overflow)" in general.

otherwise skill issue accepted

dgibso29 commented 2 months ago

Yeah in retrospect I think it makes sense to trim out "(Overflow)" and "Overflow" rather than asking MMs to update this file or manually update their slotting (more annoying than it sounds to have to go fix it 9 times)