ComboStrap / combo

Dokuwiki Combo Plugin. Making Web Publication a Breeze
https://combostrap.com
GNU General Public License v2.0
13 stars 4 forks source link

login page style not rendered by combostrap #44

Closed baudryj closed 1 year ago

baudryj commented 1 year ago

Hi, after upgrading combostrap + strap theme My login page style is not what is expected (with combo style)

Capture du 2022-09-23 10-28-50

any solution ? (option is checked in admin panel)

gerardnico commented 1 year ago

Yeah, you are right. They have introduced a new forms system and I need to do it all again.

See the igor release

New form events used. :!: Plugins should implement them, because the old form events are not triggered anymore

That's a lot of work that I don't have for now. I have just made it compatible to not break anything.

gerardnico commented 1 year ago

See https://github.com/ComboStrap/combo/issues/14 for more details. This is the preparation for the next release. There is almost 6 forms to redo. https://github.com/ComboStrap/combo/commit/ff25c0778a6dfa7f2c8b2cafc67a22e5ff8015d8

baudryj commented 1 year ago

Ok, thanks ;-) I will check it and see if I can contribute

Thanks a lot you did a very good job !

gerardnico commented 1 year ago

Thanks for the good words.

if I can find some time, I will try to do the login form.

The task is big but if i break it ... may be that I can find a time slot

baudryj commented 1 year ago

thanks ! (yep definitely login form first ;-) )

gerardnico commented 1 year ago

I don't see the why of this change, that's almost worst but I got finally some result.

image

gerardnico commented 1 year ago

Done for the login. You just need to update the combo plugin. The code has been updated but not the version. Hopefully, I didn't break anything.

Can you do an update and tell me if this is good for you ? It works on my side.

baudryj commented 1 year ago

It works ;-) My 2ndbrain login page looks good !! I re-install combo plugin (no update available) Great Job ! Capture du 2022-09-25 14-10-53

gerardnico commented 1 year ago

Entre français, un peu d'entraide :) Joli logo, c'est pour quel site ?

baudryj commented 1 year ago

C'est pour mon site perso dans mon labo (en construction). Objectif : j'utilise et je veux généraliser l'utilisation de dokuwiki avec combostrap dans le labo Use case : page perso / site projets / doc projet Pourquoi : j'ai pas envie d'avoir plusieurs outils à gérer et en général les besoins sont simples ... les sites bougent peu Combostrap permet de s'adapter à différents usages donc c'est bon pour moi !! Je pourrais te communiquer les résultats d'ici un mois !

gerardnico commented 1 year ago

Dans la derniere version, les app forms ont ete mis a jour.

C'est une grosse release, il y a des etapes manuelles a realiser. https://combostrap.com/release/release-1-25-layout-all-the-way-l17jxp17

Bonne soiree Nico