ComboStrap / combo

Dokuwiki Combo Plugin. Making Web Publication a Breeze
https://combostrap.com
GNU General Public License v2.0
15 stars 3 forks source link

User manager breaks when combo enabled #79

Open listerr opened 9 months ago

listerr commented 9 months ago

I've updated to the current version.

When I try to use the user manager to edit of find a user, I get this error:-

2024-02-22 11:41:38 /var/www/bwra.org.uk/lib/plugins/combo/ComboStrap/ExecutionContext.php(223) E_ERROR: Allowed memory size of 134217728 bytes exhausted (tried to allocate 135168 bytes)

0 [internal function]: dokuwiki\ErrorHandler::fatalShutdown()

1 {main}

If I disable Combo plugin, user manager works okay.

I have about 40 users on the system.

listerr commented 9 months ago

I tried to increase the php memory_limit:

; Maximum amount of memory a script may consume
; http://php.net/memory-limit
memory_limit = 512M

And restart everything, but doesn't change anything...

gerardnico commented 9 months ago

User manager ... ???

I don't touch it at all. I'm going to try also.

listerr commented 9 months ago

Yes.

If I go to DW Admin and go to User Manager, then try to add, edit or search users, it falls over with a 500 error, or for some reason the first time it dies, the error is displayed in a red box in the browser.

It appears to be a similar memory error as the upgrade problem, which I managed to get round for now by disabling Combo, doing the upgrades and then enabling combo again.

Rob

22 Feb 2024 12:53:41 Nickeau @.***>:

User manager ... ???

— Reply to this email directly, view it on GitHub[https://github.com/ComboStrap/combo/issues/79#issuecomment-1959399156], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAXFTQ53MQJBVSIMROL4NE3YU45VFAVCNFSM6AAAAABDUZC7DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZGM4TSMJVGY]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/AAXFTQ6ZY3UOSVYE2O2RMLDYU45VFA5CNFSM6AAAAABDUZC7DCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTUZIHPI.gif]

gerardnico commented 9 months ago

Sorry. I found it. This is because of an infinite loop.

I just made a commit. If you update Combo, it should work now. https://combostrap.com/release/how-to-update-combo-or-a-third-party-plugin-in65c0ya#how_to_update_the_combo_plugin

To be precise, the admin page had an unknown parameter and it happened that combo was logging it. During this logging, the creation of combo was started again, making an infinite loop.

Thanks Rob for the feedback Sorry for the inconvenience. Nico

gerardnico commented 9 months ago

I have installed the patch on Combostrap.com and it works. Unfortunately, there is a false warning now. May I should not show any warning on admin page.

listerr commented 9 months ago

It seemed to work after that update. But unfortunately there we too many breaking layout changes in the new Combo that I need to go through the whole site and work out how to fix. Error messages popping up about various markup that's deprecated or changed. I have had to revert everything from backups for now and just upgrade DW itself, until I can find the time to sort out all the layout issues!

gerardnico commented 9 months ago

Thanks rob.

They are just deprecation notice due to new features. The pages should work.

Unfortunatey with php and dokuwiki, modifying the pages automatically is not possible.

listerr commented 9 months ago

Hmm. After the upgrade, it seemed to make quite a mess of my site for various reasons.

Also I've used NOTOC frequently and I don't like the default numbered headings and various other things which don't look right. I seems to add a TOC whether I want it or not.

Also I have to fix a bunch of pages where I've used template variables etc.

gerardnico commented 9 months ago

Sorry for that. It’s pretty difficult to test all options. If I can help, let me know.

in the last version, there is a template engine by page. By choosing the template you include or not the toc. https://combostrap.com/theme/what-is-a-template-z9tl87hg