ComboStrikeHQ / docker-rails

An opinionated docker image for running Rails apps in production.
MIT License
89 stars 17 forks source link

Update Circleci config #28

Closed tsujigiri closed 5 years ago

hwartig commented 5 years ago

@tsujigiri Regarding the circle-ci build error we had a similar issue with the other repos as the v2 uses a more recent docker version which has different parameters

tsujigiri commented 5 years ago

@hwartig There was a permission issue with the .bundle directory. I changed it so it copies the whole app, and then sets the owner for the whole directory. I'm not sure it had anything to do with docker. Maybe bundler?

EDIT: There was another issue with the wget requests, which I had to change.

hwartig commented 5 years ago

@tsujigiri Sorry for not being clear. I'm referring to master build being broken.

Screenshot 2019-05-24 at 20 25 27

See https://github.com/ad2games/docker-rails/pull/29 for how I think it could be fixed.

tsujigiri commented 5 years ago

@hwartig Ah! Got it! :+1: