search

ComboStrikeHQ / docker-rails

An opinionated docker image for running Rails apps in production.
MIT License
89 stars 17 forks source link

Fix missing logs for appserver #6

Closed RKushnir closed 7 years ago

RKushnir commented 7 years ago

See https://github.com/puma/puma/commit/03ed48ca903879f3b9a649f5df1cf9d6577ef3d2

dziemba commented 7 years ago

Isn't that something the app should do itself when needed? Otherwise this produces a lot of noise, when not needed. Especially if you have a lot of status check requests.

RKushnir commented 7 years ago

I don't see a point in feeding the output to logger if there's never any output. You can filter the app logs out by tag if necessary.

RKushnir commented 7 years ago

Also, that behavior has changed because of the puma update, not because we explicitly decided it.

dziemba commented 7 years ago

Ah okay, so this suppresses all app log output? That's not what we want, of course.

RKushnir commented 7 years ago

Exactly.

dziemba commented 7 years ago

🍄

(please add the change to CHANGELOG and squash-merge when tests are green)