CombustibleToast / StratagemHeroOnline

36 stars 23 forks source link

Feature proposal: drill mode #34

Open Baksztag opened 2 months ago

Baksztag commented 2 months ago

Hi! Thanks for the app, I really enjoy it. I was looking for an app that would let me practice selected stratagems but couldn't find one. This one seems close but lacks some features. I've also seen similar requests: https://github.com/CombustibleToast/StratagemHeroOnline/issues/30, https://github.com/CombustibleToast/StratagemHeroOnline/issues/31, https://github.com/CombustibleToast/StratagemHeroOnline/issues/29, https://github.com/CombustibleToast/StratagemHeroOnline/issues/6.

I've spent some time to extend the app with drill mode for my use case, but I might as well share it with others.

Here's an overview of how it works:

Drill mode might be easily extended to include additional config options like:

Please let me know If you're interested. I've got the changes ready on my local branch. I'd be glad to make a pull request and discuss the details :)

choidavid4 commented 2 months ago

Was looking exactly for this and was about to start developing it myself @CombustibleToast please let him add it to the game!

CombustibleToast commented 2 months ago

Yes! Please create a PR

Baksztag commented 2 months ago

Thing is I can't push my local branch to the remote, I get a 403 :( I think you'd have to grant me permissions

CombustibleToast commented 2 months ago

Once your forked repo is up to date, you can open a PR from Github like this: image

Baksztag commented 2 months ago

Ah so it must be forked. Thanks! Here it is: https://github.com/CombustibleToast/StratagemHeroOnline/pull/35