search

Comcast / Xooie

Important note: this project is no longer actively maintained. Xfinity Xooie - Modular, Modifiable, Responsive, Accessible
Apache License 2.0
14 stars 20 forks source link

Carousel: goto 1 item returns unexpected position #84

Closed helenezspeer closed 10 years ago

helenezspeer commented 10 years ago

I would expect goto 1 item to calculate to pos 0, but it's doing something else. I can't tell exactly what. :) For items > 1, the goto code is a big improvement over the workaround I was using.

andrewlarkin commented 10 years ago

Fixed. Improper index detection. Fix is in master now, will go out with 1.0.6 gem officially.

On Sat, Nov 30, 2013 at 11:31 PM, helenezspeer notifications@github.comwrote:

I would expect goto 1 item to calculate to pos 0, but it's doing something else. I can't tell exactly what. :) For items > 1, the goto code is a big improvement over the workaround I was using.

— Reply to this email directly or view it on GitHubhttps://github.com/Comcast/Xooie/issues/84 .

Andrew Larkin