search

Comcast / ansible-sdkman

An Ansible role that installs, configures, and manages SDKMAN
https://galaxy.ansible.com/Comcast/sdkman/
Apache License 2.0
58 stars 28 forks source link

Fix issue with python package libselinux-python3 #55

Closed danielporto closed 3 years ago

danielporto commented 4 years ago

The new versions of Centos/Redhat changed the libselinux package and deprecated python 2. No default python is set after installing the python package. That created two issues: one the sdkman package fails to install due the lack of libselinux-python3, and two, the molecule test fails due to missing packages and configurations at the default docker image available in the official centos dockerhub repository.

This PR fixes both things. They need to go together otherwise it wont be possible to test the fix for the python package which only fails for el8 onwards.

ghost commented 4 years ago

Anywhere you added RHEL/CentOS 8, you can also add Fedora 31.

danielporto commented 4 years ago

I checked why the build bot failed but it seems that is not specific to my PR. Maybe the script must also be updated?

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

elliotweiser commented 3 years ago

Finally fixed my local system. I should be able to review/test soon.

elliotweiser commented 3 years ago

Superseded in #58. Apologies for the delay. My hope is that, going forward, the CI challenges will have abated, enabling me to more easily to accept PRs.