no longer erroring during detection

Comcast / ansible-sdkman

An Ansible role that installs, configures, and manages SDKMAN

https://galaxy.ansible.com/Comcast/sdkman/

Apache License 2.0

58 stars 28 forks source link

no longer erroring during detection #56

Closed SnowCone161803 closed 2 years ago

SnowCone161803 commented 3 years ago

this removes the 'ignored' errors when running the role

Not a contribution: I think the best solution is to use lineinfile (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/lineinfile_module.html), but I don't know what the implications of this are.

CLAassistant commented 3 years ago

All committers have signed the CLA.

elliotweiser commented 3 years ago

There are some ongoing challenges with the CI, but I'll look into testing this as soon as I can. I'm not sure what the repercussions are of failed_when versus ignore_errors. I'm open to looking into using the lineinfile module as well, but again will need to consider the impact.

elliotweiser commented 3 years ago

I've finally fixed my local system so I can pick this up again soon.

elliotweiser commented 2 years ago

Looks like this was superseded in #65. Thank you for your contribution all the same.