search

Comcast / gaad

GAAD (Go Advanced Audio Decoder)
Apache License 2.0
126 stars 19 forks source link

Fixes for two of the fuzzing issues #12

Closed WillGunther closed 6 years ago

WillGunther commented 6 years ago

Notes

I'll preface this by saying I didn't reference the spec for these two issues. The first fix is that the Scale Factor Index table only goes to 11 in the look up table. This fix addresses issue #10

The second fix just ensures that the Raw_data_block_position array is not accessed out of bound. This addresses issue #9

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

WillGunther commented 6 years ago

Thanks for the feedback! I went back and checked the specs. For the raw_data_blocks it just needed a larger slice as it is A field indicating how many raw data blocks are multiplexed (number_of_raw_data_blocks_in_frame+1). You were also right on that being the wrong place to address the issue. The actual issue is that the num_swb_long_windows did not include values for 7.35 kHz because it is not included in the spec. I used the values for 8 kHz which is the same strategy that libav uses.

BlakeOrth commented 6 years ago

This looks better, nice.