search

Comcast / go-edgegrid

A Golang Akamai API client and Akamai OPEN EdgeGrid Authentication scheme authentication handler.
Other
16 stars 8 forks source link

Please make #8

Closed mdb closed 8 years ago

mdb commented 8 years ago

This addresses issue #2, as well as addresses go vet concerns.

mdb commented 8 years ago

@ChrisHines Thanks! Apologies for overlooking that; I've made another commit per your continued feedback.

ChrisHines commented 8 years ago

You may ignore my advise about the method names if you think the current names are more familiar to your users for reasons specific to the domain. But I think the advise for restructuring the comments is still sound.

mdb commented 8 years ago

@ChrisHines Thanks - Your method naming suggestion is valid and worthy of consideration, though I think it may be beyond the scope of what this PR seeks to address. Do you disagree?

ChrisHines commented 8 years ago

@mdb Sure. The method naming style isn't checked by go vet or golint. If you like my suggestion a separate PR make sense, otherwise ignore it.