search

Comcast / gots

MPEG Transport Stream handling in Go
Other
308 stars 88 forks source link

packet/adaptationfield: private data length is not safely handled #82

Closed kortschak closed 6 years ago

kortschak commented 6 years ago

In create.go, SetPrivateData takes a []byte for writing to private data.

Currently this does not check for length and will panic if b is too long.

kortschak commented 6 years ago

This was updated by #84, so now it does not panic, but it does still not correctly handle cases where len(af) is not 4. I just now notice that it should also set the transport private data flag, which it currently does not. It looks to me like this will be addressed in #92.