search

Comcast / jrugged

A Java libary of robustness design patterns
Apache License 2.0
266 stars 93 forks source link

Property Place holder for namespaced attributes is not working #1

Open joercampbell opened 11 years ago

joercampbell commented 11 years ago

What steps will reproduce the problem? As per the wiki page https://github.com/Comcast/jrugged/wiki/Spring-Namespace-Example, I can use property place holder for jrugged:perfmon attribute to turn performance monitoring On/Off by just making changes in property file. However, spring doesn't support BeanFactoryPostProcessor for namespaced attributes and tags. Thus leaving properties referred as ${propertyKey} as it is when the PerformanceMonitor bean created in Decorator.

What is the expected output? What do you see instead? ${propertyName} in xml configuration for jrugged:perfmon or jrugged:methods should be replaced with "propertyValue" configured in properties file using Post processor. Or, this deficiency should be be noted in the wiki page.

What version of the product are you using? On what operating system? Jrugged 2.4 (core and spring)

Please provide any additional information below.

joercampbell commented 11 years ago

Yeah - this is certainly a problem, but I am not sure what the good fix for this is as I believe there is going to be a bean life-cycle issue when attempting to make this work right. I will continue to look for a 'decent' solution to this. Thanks Tamil.

joercampbell commented 11 years ago

So this is going to take some time to fix because we need to re-work the life cycle of the beans and our interaction with spring. Going to have to wait for now.