search

Comcast / jrugged

A Java libary of robustness design patterns
Apache License 2.0
266 stars 93 forks source link

Remove log4j as a dependency #10

Closed michajlo closed 11 years ago

michajlo commented 11 years ago

Currently JRugged leaks log4j into end users' projects as a transient dependency. While this is generally overlooked it is often not desired.

Up slf4j version to 1.7.0 so it defaults to the NOP binding if no other bindings are available, allowing the log4j binding to be taken out of the dependencies. The NOP default behaviour is available since 1.6.0, so that version can be tweaked if wanted.

I'm not sure whether or not there should be a binding specified for the test scope. My natural inclination is not to until there is demand, but there may also be some history there that I am unaware of.

joercampbell commented 11 years ago

Mishu - I am not sure how comfortable I am with making this change without rev'ing to a 3.1.0 release status... so My guess is that I would wait to merge this (into master) until we get some of the other small bug fixes etc taken care off. This changes a primary dependency of this project - and may effect people to a larger degree than the 0.0.x releasing we have been doing with 3.0.