Adding "target" element to CircuitBreaker annotation.

Comcast / jrugged

A Java libary of robustness design patterns

Apache License 2.0

266 stars 93 forks source link

Adding "target" element to CircuitBreaker annotation. #24

Closed blueyoj closed 9 years ago

blueyoj commented 10 years ago

This element can identify throwables to be considered . Since this could cause some conflicts with "ignore" element, I've added a check in DefaultFailureInterpreter to make sure only one of them is set. Basically, the rule is:

If both 'ignore' and 'target' fields are empty, all throwables will be considered failures.
If only 'ignore' field is set, all throwables except ones specified in 'ignore' field will be considered failures.
If only 'target' field is set, all throwables specified in 'target' field will be considered failures.

joercampbell commented 10 years ago

Did you already update this with a new merge?

blueyoj commented 10 years ago

I haven't had chance to work on it yet.

On Friday, December 20, 2013, Joe Campbell wrote:

Did you already update this with a new merge?

— Reply to this email directly or view it on GitHubhttps://github.com/Comcast/jrugged/pull/24#issuecomment-31045141 .

joercampbell commented 10 years ago

back around to this... still an issue?

blueyoj commented 10 years ago

It would be used in the new service we are building but we have no plan to migrate to the new service yet. I will eventually need it. I have some changes for this locally but did not get a chance to complete it yet.

joercampbell commented 9 years ago

I am going to close this out - re-open when you would like to. Thanks.