search

Comcast / jrugged

A Java libary of robustness design patterns
Apache License 2.0
266 stars 93 forks source link

Add Java 7 support? #28

Closed dschiavu closed 10 years ago

dschiavu commented 10 years ago

Hi,

I've successfully built JRugged using Java 1.7. The only fix needed was to update the AspectJ dependencies -- for Java 7, AspectJ version 1.7.2 is needed, so in jrugged-aspects/pom.xml we need to update aspectjrt and aspectjweaver artifacts to version 1.7.2.

Can you include this change in mainline?

Thanks, Danijel

joercampbell commented 10 years ago

I would be happy to take the 'upgrade'... is it still compile-able as a 1.6 target?

dschiavu commented 10 years ago

I believe this is not actually related to the Java version compliance level, see (http://stackoverflow.com/questions/15678417/error-when-using-aspectj-aop-with-java-7), but to some AspectJ bugs.

I've compiled and successfully run all JRugged modules with both Java 6 and Java 7 compilers (havent't tried 1.5 though) with the newer AspectJ artifacts. All tests pass and all examples run.

joercampbell commented 10 years ago

pushed to master. I don't see any issues when i do the build locally either. We'll see what travis has to say in a few minutes - but shouldn't cause any issues.