In the course of these changes, bugs were discovered and fixed in mamba_CMTimeMakeFromString and HLSPlaylistRenditionGroupMatchingNAMELANGUAGEValidator
Change Notes
The HLSValidatorTests were discovered to be dependent on a shared state (Xcode 10 has unit test randomization and parallelization). Those tests were fixed.
There was a bug in mamba_CMTimeMakeFromString where the "remainder" was not being calculated properly. That has been fixed and unit tests were added for the remainder (this was not tested before and is why this slipped through).
There was a bug in HLSPlaylistRenditionGroupMatchingNAMELANGUAGEValidator where, depending on which group id was processed first, you would sometimes get 1 validation error and sometimes would get multiple validation errors. My fix is slightly hacky, but I think is correct: Since all the errors returned are the same, there's no point in returning multiple errors. We just return on the first error we find.
Bumped version number for release.
Pre-submission Checklist
[x] I ran the unit tests locally before checking in.
[x] I made sure there were no compiler warnings before checking in.
[x] I have written useful documentation for all public code.
[x] I have written unit tests for this new feature.
Description
This PR updates mamba to Xcode 10.
In the course of these changes, bugs were discovered and fixed in
mamba_CMTimeMakeFromStringandHLSPlaylistRenditionGroupMatchingNAMELANGUAGEValidatorChange Notes
HLSValidatorTestswere discovered to be dependent on a shared state (Xcode 10 has unit test randomization and parallelization). Those tests were fixed.mamba_CMTimeMakeFromStringwhere the "remainder" was not being calculated properly. That has been fixed and unit tests were added for the remainder (this was not tested before and is why this slipped through).HLSPlaylistRenditionGroupMatchingNAMELANGUAGEValidatorwhere, depending on which group id was processed first, you would sometimes get 1 validation error and sometimes would get multiple validation errors. My fix is slightly hacky, but I think is correct: Since all the errors returned are the same, there's no point in returning multiple errors. We just return on the first error we find.Pre-submission Checklist