Add support for Pantos tag EXT-X-BITRATE.

youngkin commented 5 years ago

There was also a minor change to mamba.xcworkspace/contents.xcworkspacedata to remove a hardcoded path to the mambaPlayground.

Description

This PR implements support for a new Pantos tag, EXT_X_BITRATE (see the HLS Spec for details).

Change Notes

Added new test file, "mambaTests/Tag Parser Tests"/EXT-X-BITRATETagParserTests.swift.
Extended mambaSharedFramework/Pantos-Generic HLS Playlist Parsing/PantosTags.swift to include the new tag.

Pre-submission Checklist

[x] I ran the unit tests locally before checking in.
[x] I made sure there were no compiler warnings before checking in.
[x] I have written useful documentation for all public code.
[x] I have written unit tests for this new feature.

CLAassistant commented 5 years ago

All committers have signed the CLA.

youngkin commented 5 years ago

Both suggestions sound good to me. I'll take care of that so @dcoufal has less to complain about ;)

youngkin commented 5 years ago

I didn't add a negative test to cover values that couldn't be converted to a Double since there's already a test for that for another tag (EXT-X-TARGETDURATION). It would just exercise the same (validator) code with the added expense of more test code to maintain.

Comcast / mamba