This PR reworks internal data storage slightly to remove a dependency on Data/NSData internal behavior by using our own internal data storage class StaticMemoryStorage instead.
Also contains Xcode 10.2 warning fixes.
Change Notes
Added new class StaticMemoryStorage as a way of storing data in memory statically under mamba control. HLSPlaylistCode now uses this class to retain memory.
Fixes many Xcode 10.2 warnings.
Xcode 10.2 exposed a defect in how we are sorting by Resolution. That unit test is commented out for now (a second PR will restore the unit test and fix the sort behavior).
Pre-submission Checklist
[x] I ran the unit tests locally before checking in.
[x] I made sure there were no compiler warnings before checking in.
[x] I have written useful documentation for all public code.
[x] I have written unit tests for this new feature.
Description
This PR reworks internal data storage slightly to remove a dependency on
Data/NSDatainternal behavior by using our own internal data storage classStaticMemoryStorageinstead.Also contains Xcode 10.2 warning fixes.
Change Notes
StaticMemoryStorageas a way of storing data in memory statically under mamba control.HLSPlaylistCodenow uses this class to retain memory.Pre-submission Checklist