Cache the `playlistType` for `VariantPlaylist`. Invalidate the cache when changes are made. - Githubissues

Comcast / mamba

Mamba is a Swift iOS, tvOS and macOS framework to parse, validate and write HTTP Live Streaming (HLS) data.

Apache License 2.0

177 stars 37 forks source link

Cache the `playlistType` for `VariantPlaylist`. Invalidate the cache when changes are made. #56

Closed dcoufal closed 5 years ago

dcoufal commented 5 years ago

Description

This PR implements #41 .

The playlistType is now maintained by the PlaylistStructure and the VariantPlaylist just asks the structure for its value.

The PlaylistStructure value is calculated when the structure is calculated. It's recalculated whenever tag changes are made.

This should be a minor performance improvement for code that checks playlistType often.

Change Notes

Make PlaylistTypeDetermination part of the variant structure system.
Store playlistType in the variant structure system.
Calculate playlistType on init.
Recalculate playlistType on both rebuild of the structure and on "changed".
VariantPlaylist now just defers to the variant structure on the playlistType value.

Pre-submission Checklist

[x] I ran the unit tests locally before checking in.
[x] I made sure there were no compiler warnings before checking in.
[x] I have written useful documentation for all public code.
[x] I have written unit tests for this new feature.