search

Comcast / mamba

Mamba is a Swift iOS, tvOS and macOS framework to parse, validate and write HTTP Live Streaming (HLS) data.
Apache License 2.0
178 stars 39 forks source link

HLSWriter.write fatal error using CocoaPods #6

Closed chowey closed 6 years ago

chowey commented 6 years ago

Expected Behavior

Install mamba with CocoaPods. HLSWriter.write should work.

Observed Behavior

HLSWriter.write gives an error Fatal error: Unable to find framework bundle: file /path/to/project/Pods/mamba/mambaSharedFramework/Mamba.swift, line 29

Workaround

In Pods/mamba/Support Files/Info.plist, change the "Bundle identifier" to "com.comcast.mamba".

morrowa commented 6 years ago

My suggested permanent fix for this issue will be to change Mamba.version to use Bundle(for: HLSParser.self) instead of using a hard-coded bundle identifier.

However, we should also update the Info.plist.

I'll submit a PR on Monday if @dcoufal doesn't get to it before me.

dcoufal commented 6 years ago

Yeah, i think we should use Bundle(for: HLSParser.self) as well. We'd have to do some post install shenanigans in the podspec to make it work.

Thanks @chowey ! We use carthage so we were blissfully ignorant. We'll update our tester apps (at https://github.com/dcoufal/mamba_test_apps) to testing writing as well (right now it only tests parsing)

dcoufal commented 6 years ago

Fixed in 1.0.1. Closing.