Removing broken utility methods on Array<HLSTag> (1.x branch) - Githubissues

Comcast / mamba

Mamba is a Swift iOS, tvOS and macOS framework to parse, validate and write HTTP Live Streaming (HLS) data.

Apache License 2.0

177 stars 36 forks source link

Removing broken utility methods on Array<HLSTag> (1.x branch) #80

Closed dcoufal closed 4 years ago

dcoufal commented 4 years ago

Description

This PR removes some methods that were not working correctly.

We're sorry to break existing functionality, but if you were using these methods, they were likely incorrect in some cases and should be replaced.

Change Notes

Removed hasSap sapStreams hasAudioOnlyStream firstAudioOnlyStreamInfTag and filteredByVideoCodec from the Array extension.

Pre-submission Checklist

[x] I ran the unit tests locally before checking in.
[x] I made sure there were no compiler warnings before checking in.
[x] I have written useful documentation for all public code.
[x] I have written unit tests for this new feature.