Comcast / mamba

Mamba is a Swift iOS, tvOS and macOS framework to parse, validate and write HTTP Live Streaming (HLS) data.
Apache License 2.0
182 stars 40 forks source link

Swift Package Manager Support for v. 1.5.0. #98

Closed eduardoperez-nbcuni closed 4 years ago

eduardoperez-nbcuni commented 4 years ago

Description

This PR implements Swift Package Manager support for the released version 1.5.0.

Change Notes

Pre-submission Checklist

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

eduardoperez-nbcuni commented 4 years ago

Most of my comments are about lessening the impact on the project by having SPM support (removing symlinks, removing preprocessor macros, removing double defines). Please give me feedback if they make supporting SPM impossible.

Also, we use the branch structure develop/main. develop is for work being done and it the "bleeding edge". main is for releases. PR's go into develop unless they represent a release.

In our project develop_1.x is the correct target for 1.x updates, if you could repoint your PR or close this one and make a new one, that would be helpful.

Thanks for the PR!

Thank you for your feedback, David. I have created a new PR that points to develop_1.x and I have applied the requested changes in here. I will close this one so we can focus on the new PR. Thank you!