Closed eduardoperez-nbcuni closed 4 years ago
Most of my comments are about lessening the impact on the project by having SPM support (removing symlinks, removing preprocessor macros, removing double defines). Please give me feedback if they make supporting SPM impossible.
Also, we use the branch structure
develop
/main
.develop
is for work being done and it the "bleeding edge".main
is for releases. PR's go intodevelop
unless they represent a release.In our project
develop_1.x
is the correct target for 1.x updates, if you could repoint your PR or close this one and make a new one, that would be helpful.Thanks for the PR!
Thank you for your feedback, David. I have created a new PR that points to develop_1.x
and I have applied the requested changes in here. I will close this one so we can focus on the new PR.
Thank you!
Description
This PR implements Swift Package Manager support for the released version 1.5.0.
Change Notes
Package.swift
to implement the Swift Package manifest.HLSStringRef
,HLSRapidParser
,CMTimeMakeFromString
,RapidParserMasterParseArray
.mamba
. (Which is the only target exposed to be implemented).Library
.internal
folder that contains symlinks files used to expose their public headers. More information about this in here. In the sectionPUBLIC INTERFACES
Exports.swift
was created. This class exposes Objective-C public headers for Swift use. More information about this in here. In the sectionEXPOSING YOUR OBJC TO SWIFT USERS
Pre-submission Checklist