search

Comcast / php-legal-licenses

A utility to help generate a file containing information about dependencies including the full license text.
https://packagist.org/packages/comcast/php-legal-licenses
Apache License 2.0
75 stars 25 forks source link

Issue with execute() expecting an integer return in symfony 5 #14

Closed matijaboban closed 4 years ago

matijaboban commented 4 years ago

HI @orediggerco, it seems that the update to symfony/console and symfony/process update to ~5.0 in v1.1.3 (#12 ) introduced an issue related to expected execute() output, as it is expected as integer now.

This is causing the following issue when running the command:

Return value of "Comcast\PhpLegalLicenses\Console\GenerateCommand::execute()" must be of the type int, NULL returned.

I've taken a quick look at the documentation at Symfony console docs and opened a simple PR (#13 ) to solve this.

Please note that as the project doesn't seem to have exposed unit tests, I haven't included any in the PR.

orediggerco commented 4 years ago

Thanks for catching this @matijaboban! I'll review the PR this morning.

orediggerco commented 4 years ago

Closed with #13