Comcast / php-legal-licenses

A utility to help generate a file containing information about dependencies including the full license text.
https://packagist.org/packages/comcast/php-legal-licenses
Apache License 2.0
75 stars 25 forks source link

[BUG] Requirements prevent installation with Symfony 7.0 dependencies present #24

Open MArmourTCCC opened 5 months ago

MArmourTCCC commented 5 months ago

Describe the bug Same as this previous issue but for version 7.0.

To Reproduce Steps to reproduce the behavior:

  1. composer require symfony/console=7.0
  2. composer require Comcast/php-legal-licenses
  3. See error:
    Problem 1
    - Root composer.json requires comcast/php-legal-licenses ^1.2 -> satisfiable by comcast/php-legal-licenses[v1.2.0].
    - comcast/php-legal-licenses v1.2.0 requires symfony/console ~2.3|~3.0|~4.0|~5.0|~6.0 -> found symfony/console[v2.3.0, ..., v2.8.52, v3.0.0, ..., v3.4.47, v4.0.0, ..., v4.4.49, v5.0.0, ..., v5.4.36, v6.0.0, ..., v6.4.4] but it conflicts with your root composer.json require (7.0).

Expected behavior The install is successful.

Run Environment (please complete the following information): N/a

Pull Request PR Request Added

mcsma commented 4 months ago

@orediggerco did you consider merging @MArmourTCCC s PR? symfony 7 compatability is currently limiting the use of this software. Would greatly appreciate you having a look.

orediggerco commented 4 months ago

Hey @mcsma, thanks for the report! I'm reviewing the PR now

mcsma commented 4 months ago

Thanks @orediggerco and thanks @MArmourTCCC for the effort on making it work on symfony7!

In the meantime I found an article on how to require the PR branch from @MArmourTCCC:

In the composer.json add the following:

"require": {
    "comcast/php-legal-licenses": "dev-add-support-for-symfony-7"
}

…as well as the redirect where the specific PR branch is found:

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/MArmourTCCC/php-legal-licenses.git",
        "only": ["comcast/php-legal-licences"]
    }
]

… and finally run composer update comcast/php-legal-licenses.

Source: https://stackoverflow.com/a/55307273

orediggerco commented 4 months ago

PR #25 has been merged. Thanks @MArmourTCCC and @mcsma !

mcsma commented 4 months ago

Thank you sir!