Comcast / plax

A test automation engine for messaging systems
Apache License 2.0
7 stars 14 forks source link

Zero string value for X_ parameter results in crazy-bad redactions #141

Closed jsccast closed 2 years ago

jsccast commented 3 years ago

See below for an example.

Should check that a X_ parameter value is not the empty string before using it for redactions.

bindings:
  '?X_OOPS': ''
spec:
  phases:
    phase1:
      steps:
        - pub:
            payload:
              make:
                name: mock
                type: mock
        - recv:
            chan: mother
            pattern:
              success: true
        - pub:
            payload: '42'
        - recv:
            pattern: '"?x"'
2021/10/29 14:13:12.440930 <redacted>|<redacted> <redacted> <redacted> <redacted> <redacted> <redacted> <redacted> <redacted>t<redacted>.<redacted>B<redacted>i<redacted>n<redacted>d<redacted>i<redacted>n<redacted>g<redacted>s<redacted>:<redacted> <redacted>{<redacted>"<redacted>?<redacted>X<redacted>_<redacted>O<redacted>O<redacted>P<redacted>S<redacted>"<redacted>:<redacted>"<redacted>"<redacted>,<redacted>"<redacted>?<redacted>x<redacted>"<redacted>:<redacted>4<redacted>2<redacted>}<redacted>