search

Comcast / sirius

A distributed system library for managing application reference data
http://comcast.github.io/sirius/
Apache License 2.0
298 stars 49 forks source link

Prohibit null RequestHandler #12

Closed smuir closed 10 years ago

smuir commented 10 years ago

Not sure what this will look like

comcast-jonm commented 10 years ago

This should probably throw an IllegalArgumentException rather than a NPE, per common convention. Also, it would be nice to see a unit test to go with this.

smuir commented 10 years ago

Yes, I half expected that someone would tell me to use IllegalArgumentException, didn't know the convention but figured this was a reasonable way to find out. I will hack up a quick unit test.

smuir commented 10 years ago

This request probably needs to be resubmitted in a cleaner format, i.e., without including the various merge commits. I will try to do so.