Comcast / sirius

A distributed system library for managing application reference data
http://comcast.github.io/sirius/
Apache License 2.0
298 stars 49 forks source link

Upgrade to Akka 2.4 #124

Closed paulcleary closed 7 years ago

paulcleary commented 8 years ago

Most of the changes are in the build setup. We are no longer using an external POM file to manage sirius, purely SBT.

joercampbell commented 8 years ago

Just out of curiosity - This akka upgrade isn't breaking like the last one (from a binary message perspective between actors) is it?

paulcleary commented 8 years ago

@joercampbell this is a WIP only; just wanted to post it so others can take a look. Told PC2 I would post it to see what changed.

We would definitely need to do some backward compatibility testing. There is quite a roadmap that we would need to go through before this can be merged. That is something PC2 and I will discuss in the coming week or so.

So far, this has only been tested in a multi-node cluster for a new implementation.

clinedome-work commented 7 years ago

@paulcleary a couple things: one, can you change the .travis.yml to hit 2.11.8 instead of 2.10.2. Two, please undelete the Build.scala file so we can build the standalone artifact.

@joercampbell unfortunately, I think the upgrade from scala 2.10.2 to 2.11.8 does introduce serialization changes that will cause mixed-version clusters to have problems during a rolling upgrade. Same as the last major upgrade, we'll need to account for this fact in the release notes, and make sure folks know as they go into the upgrade process. I don't think there's a short away around it for this.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

paulcleary commented 7 years ago

@clinedome-work I made the adjustments.