search

Comcast / sirius

A distributed system library for managing application reference data
http://comcast.github.io/sirius/
Apache License 2.0
298 stars 49 forks source link

Clean up a bunch of warnings #154

Closed HaloFour closed 3 years ago

HaloFour commented 3 years ago

Mostly cleaning up unused imports and removing deprecated procedure syntax. Due to cross compilation we'll never be able to eliminate the compiler warnings but I would like to get close.

codecov-commenter commented 3 years ago

Codecov Report

Merging #154 (a2eb76e) into master (3d31c3e) will increase coverage by 0.02%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   72.83%   72.86%   +0.02%     
==========================================
  Files          66       66              
  Lines        1833     1835       +2     
  Branches       73       79       +6     
==========================================
+ Hits         1335     1337       +2     
  Misses        498      498
Impacted Files Coverage Δ
...comcast/xfinity/sirius/admin/MonitoringHooks.scala 100.00% <ø> (ø)
...mcast/xfinity/sirius/api/SiriusConfiguration.scala 21.05% <ø> (ø)
...m/comcast/xfinity/sirius/api/impl/SiriusImpl.scala 100.00% <ø> (ø)
...ast/xfinity/sirius/api/impl/SiriusSupervisor.scala 95.65% <ø> (ø)
...ity/sirius/api/impl/bridge/CatchupSupervisor.scala 93.54% <ø> (ø)
...nity/sirius/api/impl/bridge/PaxosStateBridge.scala 92.68% <ø> (ø)
...y/sirius/api/impl/membership/MembershipActor.scala 86.95% <ø> (ø)
...mcast/xfinity/sirius/api/impl/paxos/Acceptor.scala 88.46% <ø> (ø)
...comcast/xfinity/sirius/api/impl/paxos/Leader.scala 89.25% <ø> (-0.83%) :arrow_down:
...t/xfinity/sirius/api/impl/paxos/LeaderHelper.scala 100.00% <ø> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d31c3e...a2eb76e. Read the comment docs.