Comcast / sirius

A distributed system library for managing application reference data
http://comcast.github.io/sirius/
Apache License 2.0
298 stars 49 forks source link

add membership health check #92

Closed tbarker9comcast closed 10 years ago

tbarker9comcast commented 10 years ago

checking if the membership map is healthy based on a last ping threshold

I think this needs a little refinement, specifically with the algorithm and the functional work on the lastPingThreshold.

tbarker9comcast commented 10 years ago

I made some improvements and rebased them in

tbarker9comcast commented 10 years ago

:-1: there are some problems I am fixing

clinedome-work commented 10 years ago

Looking pretty good. A few comments, mostly style stuff.

It also seems like one of the MembershipActor tests isn't passing.

clinedome-work commented 10 years ago

Ok, I like this. Has my :+1:. Nice work!