Comcast / xGitGuard

AI based Secrets Detection Python Framework
Apache License 2.0
59 stars 27 forks source link

argparse inconsistancy on accepted vs recomened inputs #4

Closed stiliajohny closed 2 years ago

stiliajohny commented 2 years ago

https://github.com/Comcast/xGitGuard/blob/ae109f5f91b2fa58ff9434e0ca6adbfbb3c0162c/xgitguard/models/model.py#L153-L154

The suggested help doesn't match the expected values, Would you consider changing this to

 choices=["key", "cred"], 
- help="Pass the Data_Type as Cred or Key", 
+ help="Pass the Data_Type as cred or key", 

Or

- choices=["key", "cred"], 
+ choices=["key", "cred", "Key", "Cred"], 
 help="Pass the Data_Type as Cred or Key", 
SARAVA01 commented 2 years ago

Thanks for reporting. Same has been addressed in latest code. Thanks.