[Feature Request]: in-progress preview node

Comfy-Org / ComfyUI_frontend

Official front-end implementation of ComfyUI

https://www.comfy.org/

GNU General Public License v3.0

493 stars 69 forks source link

[Feature Request]: in-progress preview node #1093

Open JorgeR81 opened 1 day ago

JorgeR81 commented 1 day ago

Is there an existing issue for this?

[X] I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

I'd like to separate the KSampler node from the in-progress preview image. I want a larger preview, especially with wider images, without having to increase the size of the other widgets.

This would be more useful now, because we can have larger previews ( e.g. --preview-size 768 )

Since we can have previews in queue ( https://github.com/Comfy-Org/ComfyUI_frontend/pull/1091 ), is it possible to have an independent in-progress preview node ?

prev3

Proposed workflow

If previews are enabled, the KSampler would have an extra output to connect it to an "in-progress preview" node. If a connection is made, the preview inside the KSampler, would be disabled.

The "in-progress preview" and Image Preview nodes, could also be grouped in a single node.

Additional information

No response

LukeG89 commented 18 hours ago

@JorgeR81 I don't think they can do anything about it. As a new node, you should request it in the main repo or in another custom nodes (e.g. Custom Scripts, rgthree, etc.).

However, I have a suggestion. Instead of a connection, you could associate the in-progress preview node using the node ID. This way, you can associate it to every sampler nodes (KSampler, Sampler Custom, etc.) or any other nodes that display a preview.

JorgeR81 commented 16 hours ago

@JorgeR81 I don't think they can do anything about it. As a new node, you should request it in the main repo or in another custom nodes (e.g. Custom Scripts, rgthree, etc.).

However, I have a suggestion. Instead of a connection, you could associate the in-progress preview node using the node ID. This way, you can associate it to every sampler nodes (KSampler, Sampler Custom, etc.) or any other nodes that display a preview.

I've opened an issue in the main repo.

About the wired connection, yeah, I'm not sure if that would be the best solution, because the KSampler and the in-progress node would have to somehow be active at the same time ? ...

LukeG89 commented 16 hours ago

I don't know how previews work, but I think displaying them both within KSampler and in-progress node doesn't affect performance or anything, it's just the same preview displayed in two nodes.

The wired connection is quite inconvenient because all samplers should have a dedicated output just to connect to in-progress.

JorgeR81 commented 15 hours ago

I don't know how previews work, but I think displaying them both within KSampler and in-progress node doesn't affect performance or anything, it's just the same preview displayed in two nodes.

I meant more about the consistency in the GUI "logic" of showing only one active node at a time ( with the green border ). ( But I gess both nodes could have the green border or something ).

The wired connection is quite inconvenient because all samplers should have a dedicated output just to connect to in-progress.

I don't need to have a wire, but it would be nice to have a preview only in some KSamplers, to have a visually simpler workflow / canvas. For instance I want an in progress preview for main Sampler, but I don't need it in the refiner / upscaler.