search

Comfy-Org / ComfyUI_frontend

Official front-end implementation of ComfyUI
https://www.comfy.org/
GNU General Public License v3.0
605 stars 109 forks source link

[Bug]: Title for new group cannot be edited right away #1547

Open alessandroperilli opened 4 hours ago

alessandroperilli commented 4 hours ago

Frontend Version

1.3.44 (but the bug has been there for some versions)

Expected Behavior

Once a new group has been created, it's assigned the title Group. At this point, double-clicking on that title would enable the user to edit the title, as it normally happens with existing groups.

Actual Behavior

Double-clicking on a newly created group enables the title edit UI, but nothing being typed appears on screen. It seems like the UI is stuck. The only way to move forward is press Return/Enter, and then type the new title you want. No visual cue appears once you press Enter/Return.

Steps to Reproduce

  1. Create a new group.
  2. Double-click on the title.
  3. Try to type a new title. Nothing should appear on screen.
  4. Press Return/Enter
  5. Try to type a new title again. At this point, you should see the text changing.
  6. Hit Return/Enter to save the new title.

Debug Logs

None relevant

Browser Logs

None

Setting JSON

None relevant

What browsers do you use to access the UI ?

Other

Other

Vivaldi on macOS, but it also happens with Safari.

LukeG89 commented 2 hours ago

I tried to reproduce your issue, but editing group title works fine to me.

The only problem I see is that when you create the group, the edit title dialog appears far from the Group. You need to close the dialog to be able to double-click to edit the group title.

Edit: There is a custom node that triggers the edit title dialog, it doesn't appear with all custom nodes disabled. Later I'll investigate.

Edit 2: Found the culprit of my little issue: rgthree-comfy. I opened a bug report there:

https://github.com/user-attachments/assets/37722ef1-2271-4d16-be17-a4a657a3c9ad

alessandroperilli commented 2 hours ago

I don't have that behavior at all. This is what happens to me (every time you see the cursor blink, it's me typing and being ignored):

https://github.com/user-attachments/assets/e635f920-9930-4ebb-b654-322ca119ca97

LukeG89 commented 1 hour ago

I think it's the same bug as this PR should have fixed (but for some reason you still have it):

alessandroperilli commented 26 minutes ago

It really seems like it, or at least connected to that.