Comfy-Org / ComfyUI_frontend

Official front-end implementation of ComfyUI
https://www.comfy.org/
GNU General Public License v3.0
633 stars 115 forks source link

[Bug]: Queue Tab Results preview up to 8 outputs only. #1639

Closed TheToxin-git closed 13 hours ago

TheToxin-git commented 3 days ago

Frontend Version

1.4.7. Pinpointed to 1.4.3+

1732268077_912009355

Expected Behavior

Queue Tab Results should preview all outputs.

Under 1.4.2:

https://github.com/user-attachments/assets/972c2b53-3d97-4ddd-a58b-33bf77f9a695

Actual Behavior

Queue Tab Results preview only 8 of it.

https://github.com/user-attachments/assets/c212a897-7cdb-4003-960d-ec40df1e5eb7

Steps to Reproduce

  1. Generate 9+ outputs
  2. Make sure you are using 1.4.3+ Frontend version
  3. Open Queue tab and check results

Demonstration shown can be reproduced with this workflow and resources (unpack to ComfyUI/input/ folder)

Debug Logs

Total VRAM 11934 MB, total RAM 31885 MB
pytorch version: 2.5.1+cu124
xformers version: 0.0.28.post3
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3060 : cudaMallocAsync
Using xformers cross attention
Initializing frontend: Comfy-Org/ComfyUI_frontend@latest, requesting version details from GitHub...
[Prompt Server] web root: /home/thetoxin/root/downloads/github/ComfyUI/web_custom_versions/Comfy-Org_ComfyUI_frontend/1.4.7
Skipping loading of custom nodes
Starting server

To see the GUI go to: http://127.0.0.1:8188
got prompt
Prompt executed in 0.13 seconds
got prompt
Prompt executed in 0.02 seconds

Browser Logs

Start-up:

unreachable code after return statement three.module.js:8173:11
load and start tracking of workflow workflows/QueueAmountTest.json workflowStore.ts:73:12
[workflowStore] open workflow workflows/QueueAmountTest.json workflowStore.ts:191:12

Execution:

queued task 4e46e534-4924-434e-aeca-78ace17431cc with 18 nodes executionStore.ts:176:12
queued task a5992927-95dc-4f2c-94a2-6ee9385081bd with 21 nodes executionStore.ts:176:12

Setting JSON

comfy.settings.json I believe settings are unrelated

What browsers do you use to access the UI ?

Mozilla Firefox

Other

Same behaviour with text output, so this is, probably, any output related.

LukeG89 commented 3 days ago

I guess this is the culprit:

huchenlei commented 3 days ago

@pythongosssss PTAL

LukeG89 commented 2 days ago

I just noticed that the 8 outputs are not only inside the single task, but also in the global tasks

https://github.com/user-attachments/assets/7f5b261f-7c7e-41cf-a475-1a8bd95bc23a