Comfy-Org / ComfyUI_frontend

Official front-end implementation of ComfyUI
https://www.comfy.org/
GNU General Public License v3.0
430 stars 52 forks source link

[Feature Request]: Remove the Black Overlay on Search Box Popup #412

Open Amorano opened 1 month ago

Amorano commented 1 month ago

Is there an existing issue for this?

What would your feature do ?

A setting to remove the overlay for the popup searching box.

Proposed workflow

  1. open settings
  2. tweak settings that we do not want enforced
  3. post more feature requests

Additional information

No response

christian-byrne commented 3 weeks ago

You can change it in ComfyUI/web/user.css:

.node-search-box-dialog-mask {
  background-color: transparent !important;
}
Amorano commented 3 weeks ago

You can change it in ComfyUI/web/user.css:

.node-search-box-dialog-mask {
  background-color: transparent !important;
}

Sounds great, but that isnt my feature request.

My request is to make it a setting.

christian-byrne commented 3 weeks ago

You can change it in ComfyUI/web/user.css:

.node-search-box-dialog-mask {
  background-color: transparent !important;
}

Sounds great, but that isnt my feature request.

My request is to make it a setting.

I feel you. Relying on user.css for advanced settings is maybe not ideal. I can PR your suggestion if you want. I don't know the thought process on simplicity vs customization balance, but since the settings are so well organized now, it seems like it should okay.

Amorano commented 3 weeks ago

You can change it in ComfyUI/web/user.css:

.node-search-box-dialog-mask {
  background-color: transparent !important;
}

Sounds great, but that isnt my feature request. My request is to make it a setting.

I feel you. Relying on user.css for advanced settings is maybe not ideal. I can PR your suggestion if you want. I don't know the thought process on simplicity vs customization balance, but since the settings are so well organized now, it seems like it should okay.

Right, which is my point. The settings are well organized, it should be a 5 miunute process to start adding these options into the panel, esp when it concerns workflow that didnt exist in the past =D

I see the settings injection code is pretty light and will look super great in a new shiny settings panel.

And I know the speed is "faster" but it is not remotely as quick, nor in place, as the old sub-menu. This really does matter when doing speedy work -- if the goal is to target a more professional setup, this is one of those things.

without-ordinary commented 1 week ago

+1 on this, its one of my many accessibility issues with the new frontend.

Edit: using this workaround, but noticed this problem.

With background dimming turned off, there is little visual separation between the new sporadic search UI elements and the canvas. This is not a unique issue here and is a general and common accessibility issue with Modern UI design. With overlapping UIs, there is little distinction between foreground and background (similar tto Windows 10/11's use no borders on windows of the same color and only have an option for a maximum of 1px window borders).

If the new search was (or optionally could be) contained within a window, that would help. But even without that, this is still preferable over the sudden dimming that is a nausea and migraine trigger for me.

Screen flashing is bad for some of us.