Closed ShmuelRonen closed 2 months ago
green-anger
commented
2 months ago Doesn't work on Chrome either. Checked in the inspector and got this:
Manually changing spellcheck to "true" fixes this. But it must be done for each separate input field.
@huchenlei Check your CSS, it's as if it was disabled for all textarea elements, it's the same for built-in and custom nodes.
huchenlei
commented
2 months ago I think the issue is here: https://github.com/Comfy-Org/ComfyUI_frontend/blob/6c557eaa583d969c901f9681cc811251b9768906/src/scripts/widgets.ts#L320
However the code is directly inherited from the legacy repo. I am not sure whether before the new frontend, there was a custom node that enables spell check that got broken
green-anger
commented
2 months ago I don't know the code and have no idea where opts come from, but why does anyone want to disable spellchecking, any valid use case for that? If not, maybe set it to true or reverse it - true by default and an option to disable it?
christian-byrne
commented
2 months ago I think the issue is here:
However the code is directly inherited from the legacy repo. I am not sure whether before the new frontend, there was a custom node that enables spell check that got broken
Git blame says #267. Should widget spellcheck be a setting? In order to make spellcheck's red underlining reactive I had to do this:
watchEffect(() => {
const spellcheckEnabled = useSettingStore().get('Comfy.TextareaWidget.Spellcheck')
const textareas = document.querySelectorAll('textarea.comfy-multiline-input')
textareas.forEach((textarea: HTMLTextAreaElement) => {
textarea.spellcheck = spellcheckEnabled
// Force recheck to ensure visual update
textarea.focus()
textarea.blur()
})
})
Frontend Version
Revision: 2546 [bfc214f4]
Expected Behavior
In text node like String Literal when I made spell mistake a red line come under the wrong spelling word.
Actual Behavior
On ComfyUI Revision: 2546 text node like String Literal when I made spell mistake a red line dose not come under the wrong spelling word.
Steps to Reproduce
i try to fix but nothing happaned
Debug Logs
Browser Logs
What browsers do you use to access the UI ?
Brave
Other
No response