search

Comfy-Org / ComfyUI_frontend

Official front-end implementation of ComfyUI
https://www.comfy.org/
GNU General Public License v3.0
575 stars 99 forks source link

Migrate node library sidebar to use unique name instead of display name #702

Closed huchenlei closed 2 months ago

huchenlei commented 2 months ago

image

The display_name is rather fragile, as they can change at different lifecycle of the node. The name field on node definition is the one that is not supposed to change and unique.

This PR deprecates Comfy.NodeLibrary.Bookmarks hidden setting field and added logic to automatically convert legacy bookmarks to new bookmarks in setting Comfy.NodeLibrary.Bookmarks.V2

huchenlei commented 2 months ago

The test failure is caused by preview overlap with the bookmark button when playwright driver tries to scroll the element leftward. Previously KSampler (Advanced) will be word breaked to 2 lines.

page@542d77d6166c06eb4133319730379abe-1725226162 511456