Comfy-Org / ComfyUI_frontend

Official front-end implementation of ComfyUI
https://www.comfy.org/
GNU General Public License v3.0
575 stars 99 forks source link

[Bug]: Safari browser can't unlock a group once locked #729

Closed MrFeverDream closed 1 month ago

MrFeverDream commented 1 month ago

Frontend Version

on Sonoma 14.6.1 Safari 17.6 but also seen much earlier: https://www.reddit.com/r/comfyui/comments/18f3ono/i_cant_edit_the_group_can_anyone_help_me/

Expected Behavior

Once a group is locked, after right click on group, edit group should be visible to unlock

Actual Behavior

After right click, edit group is not visible

Steps to Reproduce

lock a group, then try to unlock.

Debug Logs

C:\AI\ComfyUI_windows_portable>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build --listen --disable-all-custom-nodes
Total VRAM 24564 MB, total RAM 98299 MB
pytorch version: 2.3.1+cu121
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090 : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: C:\AI\ComfyUI_windows_portable\ComfyUI\web
Adding extra search path checkpoints C:\AI\stable-diffusion-webui\models/Stable-diffusion
Adding extra search path configs C:\AI\stable-diffusion-webui\models/Stable-diffusion
Adding extra search path vae C:\AI\stable-diffusion-webui\models/VAE
Adding extra search path loras C:\AI\stable-diffusion-webui\models/Lora
Adding extra search path loras C:\AI\stable-diffusion-webui\models/LyCORIS
Adding extra search path upscale_models C:\AI\stable-diffusion-webui\models/ESRGAN
Adding extra search path upscale_models C:\AI\stable-diffusion-webui\models/RealESRGAN
Adding extra search path upscale_models C:\AI\stable-diffusion-webui\models/SwinIR
Adding extra search path embeddings C:\AI\stable-diffusion-webui\embeddings
Adding extra search path hypernetworks C:\AI\stable-diffusion-webui\models/hypernetworks
Adding extra search path controlnet C:\AI\stable-diffusion-webui\models/ControlNet
Skipping loading of custom nodes
Starting server

To see the GUI go to: http://0.0.0.0:8188

Browser Logs

[Error] Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'e.type') (anonymous function) (client.js:1:177907) [Error] Source Map loading errors (x4)

What browsers do you use to access the UI ?

Apple Safari

Other

No response

huchenlei commented 1 month ago

Locking group/node is not a core feature. Please file issue in custom node repo.

807502278 commented 1 month ago

I thought this was an in-built function. May I ask which plugin does this function belong to?

MrFeverDream commented 1 month ago

No plugin AFAIK. Just right click a group and lock, and then safari doesn’t show unlock option. On 24 Sep 2024, at 10:09, 807502278 @.***> wrote: I thought this was an in-built function. May I ask which plugin does this function belong to?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

807502278 commented 1 month ago

Oh, thank you, I got it