Closed robinjhuang closed 3 months ago
@telamonian Does gpu in uv.py
class need to be a Union type of str and the GPU_OPTION
enum? That's the root cause of this uncaught bug. What if we just make the gpu
value typed as GPU_OPTION
?
@robinjhuang You make a good point. I think I made that change to make testing during development easier. I often import functions into a notebook cell to mess with them as I develop, eg:
from comfy_cli.uv import DependencyCompiler
dp = DependencyCompiler(gpu="amd", ...)
But there shouldn't be any need for it in the final product. Alright, let me make those changes and I'll add them to this PR
Because Resolve_Gpu converts a string to a GPU_Option, we need to use the exact same string as upper and lowercase.
gpu.uppper
converts the previous mac_m_series intoMAC_M_SERIES
which was a non-existent GPU_OPTION.