CPU-only mode is non-existent

Comfy-Org / comfy-cli

Command Line Interface for Managing ComfyUI

https://docs.comfy.org/comfy-cli/getting-started

GNU General Public License v3.0

288 stars 48 forks source link

CPU-only mode is non-existent #185

Open ohenepee opened 2 months ago

ohenepee commented 2 months ago

Describe the bug Installing with the --cpu option still installs all NVIDIA requirements. All the gigabytes of NVIDIA GPU dependencies were downloaded, even though I have no NVIDIA card and I specifically added --cpu. After successful installation, launching fails with RuntimeError: Found no NVIDIA driver on your system. Please check that you have an NVIDIA GPU and installed a driver from http://www.nvidia.com/Download/index.aspx

To Reproduce

python3 -m venv ./venv
source ./venv/bin/activate
pip install comfy-cli
comfy --here install --cpu
comfy launch

Expected behavior NVIDIA requirements are not needed for CPU-only installations. And there should be a way to pass the --cpu option to the comfy launch command.

ltdrdata commented 2 months ago

Oh, that's not an install option, it's a launch option. comfy launch -- --cpu

ohenepee commented 2 months ago

Oh wow, comfy launch --help doesn't show this... its rather present in comfy install --help

And actually prints "Installing for CPU" or something similar.

Thanks btw, wouldn't have figured it out.

ltdrdata commented 2 months ago

Oh wow, comfy launch --help doesn't show this... its rather present in comfy install --help

And actually prints "Installing for CPU" or something similar.

Thanks btw, wouldn't have figured it out.

Actually -- <extra args ...> is that. --cpu is arguments of ComfyUI core itself not a part of comfy-cli.

-- is used to set ComfyUI's own options. For example, you can use it like this: comfy launch -- --listen 0.0.0.0 --port 1111

snomiao commented 2 months ago

Oh wow, comfy launch --help doesn't show this... its rather present in comfy install --help And actually prints "Installing for CPU" or something similar. Thanks btw, wouldn't have figured it out.

Actually -- <extra args ...> is that. --cpu is arguments of ComfyUI core itself not a part of comfy-cli.

-- is used to set ComfyUI's own options. For example, you can use it like this: comfy launch -- --listen 0.0.0.0 --port 1111

Should we make a --help command on extra args...? @ltdrdata