search

Comfy-Org / comfy-cli

Command Line Interface for Managing ComfyUI
https://docs.comfy.org/comfy-cli/getting-started
GNU General Public License v3.0
288 stars 48 forks source link

non-interactive mode not working #215

Closed jeffcrouse closed 3 days ago

jeffcrouse commented 3 days ago

Describe the bug

168.2 ComfyUI is installed at: /comfyui
------
Dockerfile:26
--------------------
  24 |     RUN pip install -U comfy-cli
  25 |
  26 | >>> RUN /usr/bin/yes | comfy --workspace /comfyui install --cuda-version 12.1 --nvidia --version latest
  27 |
  28 |     COPY workflow.json /workflow.json
--------------------
ERROR: failed to solve: process "/bin/bash -o pipefail -c /usr/bin/yes | comfy --workspace /comfyui install --cuda-version 12.1 --nvidia --version latest" did not complete successfully: exit code: 141

To Reproduce Here's the Dockerfile https://gist.github.com/jeffcrouse/98a78ed0641c6695fac23008328e8706

Expected behavior Comfy should be successfully installed and the move on to the next command

Additional context This Dockerfile seems to use ``RUN /usr/bin/yes | comfy --workspace /comfyui install``` but it doesn't work on my system https://github.com/blib-la/runpod-worker-comfy/blob/main/Dockerfile

There also seems to be some talk of some a --skip-prompt option at https://github.com/Comfy-Org/comfy-cli/issues/128, but this also throws an error for me, saying that --skip-prompt is not an option.

Of course I can ignore the exit code with a || true but I would rather not ignore ALL errors.

jeffcrouse commented 3 days ago

Just leaving this here in case it's helpful to anyone else. I had ignorantly copied s line from another Dockerfile: SHELL ["/bin/bash", "-o", "pipefail", "-c"] that was causing the error. I still don't quite understand the concept of -o pipefail, but I understand that it's too strict about exit status